Skip to content

(#116): Remove mandatory parameter checking for namespace in /lookup #117

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
crayfishx wants to merge 5 commits into
base: master
Choose a base branch
from
Open

(#116): Remove mandatory parameter checking for namespace in /lookup #117

Changes from 2 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
980f606
(#11): Remove mandatory parameter checking for namespace in /lookup (…
crayfishx Feb 12, 2018
02076bb
handle namespace nil cases
crayfishx Feb 12, 2018
885982a
added syntax checking to Rake tasks
crayfishx Feb 14, 2018
b77b132
fixed syntax error in rest.rb
crayfishx Feb 14, 2018
f4b1e23
added test case scenario for namespaceless lookups
crayfishx Feb 14, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions lib/jerakia/server/rest.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,12 +98,15 @@ def mandatory_params(mandatory, params)
end

get '/v1/lookup/:key' do
mandatory_params(['namespace'], params)

request_opts = {
:key => params['key'],
:namespace => params['namespace'].split(/\//),
}

if params['namespace']
request_opts[:namespace] = params['namespace'].split(/\//),

@jtopjian jtopjian Feb 14, 2018

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unless I'm mistaken, the , at the end is a syntax error?

@crayfishx crayfishx Feb 14, 2018

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doh! Must add basic syntax to the rake task for testing!

end

metadata = params.select { |k,v| k =~ /^metadata_.*/ }
scope_opts = params.select { |k,v| k =~ /^scope_.*/ }

Expand Down