Repository navigation
text: make RepeatAndTrim handle escape sequences and display width - #454
Merged
Merged
Conversation
jedib0t
commented
Nov 12, 2026
jedib0t
commented
Owner
- measure the string in display columns instead of runes
- use the escape sequences found around the text once, around the repeated text, instead of counting them as text
- return an empty string for a negative width instead of panicking
- skip the trim when whole copies fill the width exactly
- let Trim take box drawing, Latin, Greek and Cyrillic characters as grapheme clusters of their own, the way it takes ASCII and CJK
- add a benchmark for RepeatAndTrim
| Benchmark | Before | After |
|---|---|---|
| RepeatAndTrim, ASCII | 90 | 12 |
| RepeatAndTrim, box drawing | 1024 | 34 |
| RepeatAndTrim, escaped | 234 | 85 |
| Table_Render | 9293 | 7652 |
| Table_RenderLarge | 2,021,179 | 2,052,288 |
- measure the string in display columns instead of runes - use the escape sequences found around the text once, around the repeated text, instead of counting them as text - return an empty string for a negative width instead of panicking - skip the trim when whole copies fill the width exactly - let Trim take box drawing, Latin, Greek and Cyrillic characters as grapheme clusters of their own, the way it takes ASCII and CJK - add a benchmark for RepeatAndTrim
|
Coverage Report for CI Build 43319784887Coverage remained the same at 99.927%Details
Uncovered ChangesNo uncovered changes found. Coverage RegressionsNo coverage regressions found. Coverage Stats
💛 - Coveralls |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.