Repository navigation
Conversation
Trim the indicator before reserving its display width, so a short target cannot be exceeded by the indicator alone. Reuse Trim to retain ANSI sequences and account for wide characters. Signed-off-by: Don Yin <Don_Yin@outlook.com>
|
Coverage Report for CI Build 39913107077Coverage remained the same at 100.0%Details
Uncovered ChangesNo uncovered changes found. Coverage RegressionsNo coverage regressions found. Coverage Stats
💛 - Coveralls |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed Changes
snipIndicatorwith the existing ANSI-awareTrimbefore reserving its display width.TestSnipwith short limits, colored and wide indicators, and an input that already fits.When the indicator is wider than the limit,
Snipcurrently drops the input but still appends the whole indicator:The one-line change keeps the indicator within the same display-width budget as the input. Inputs that already fit are unchanged.
Checked:
make test(including format, vet, lint and complexity),make test-race, andmake benchon Go 1.26.1. The new assertions fail before the production change and pass afterward.The figure shows measured output widths for plain
...and the same indicator wrapped in ANSI color sequences: