Repository navigation
Conversation
|
Coverage Report for CI Build 39819707428Coverage remained the same at 100.0%Details
Uncovered ChangesNo uncovered changes found. Coverage RegressionsNo coverage regressions found. Coverage Stats
💛 - Coveralls |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Proposed Changes
Tracker.Start()readt.timeStartwithout holdingt.mutex, whilestartWithoutLock()(reached viaIncrement,IncrementWithError,SetValueor anotherStart()) writes it under the lock. CallingStart()while another goroutine feeds progress is a data race; two concurrentStart()calls could also both see a zerotimeStartand start twice.Start()now takes the write lock, checkstimeStart.IsZero()and callsstartWithoutLock()in one critical section, the same patternIsStarted()andincrementWithoutLock()use.TestTracker_Start_Concurrent: two goroutines callStart()while two callIncrement(1)on the same tracker. Before the fix,go test -race -run TestTracker_Start_Concurrent ./progress/fails withWARNING: DATA RACE(tracker.go:202 read vs. tracker.go:261 write). After the fix it passes over 20 runs.Testing:
make test(fmt, vet, golangci-lint, gocyclo, tests with 100% coverage) andmake test-raceboth pass.