Repository navigation
Reject stale checkpoints using versioned study definitions - #147
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checkpoint reuse previously validated only phase names, so a changed grid could silently load stale results. Validate a versioned structural manifest covering grids, phase settings, objectives, factors, annotations, model code, and filter closures. Add a caller-managed checkpoint_key for model/data revisions and opaque behavior, atomically write the manifest, and validate saved observable schemas.
Closes #143.
Existing phase-name-only checkpoints are refused with instructions to use a new directory. Instance state, globals, and external data require a caller-managed revision; checkpoints do not serialize live model objects.
Validation:
just ci; regressions cover changed grids, replication/trial counts, objective directions, factors, filter closures, revisions, legacy manifests, opaque callables, incompatible phase schemas, valid resumes, and external phase results. Strict docs build also checks the checkpoint guide.