Add png file json file unique name and take different editOptions - #214
Open
JorisGoosen wants to merge 3 commits into
Open
Add png file json file unique name and take different editOptions#214JorisGoosen wants to merge 3 commits into
JorisGoosen wants to merge 3 commits into
Conversation
added 3 commits
July 27, 2026 20:34
The response used the local 'plot' variable (original, pre-editing) instead of jaspPlotCPP (which is updated to newPlot when editing succeeds). This caused imageEdited() on the desktop to receive and store the pre-edit editOptions, corrupting the user's plot customizations.
Contributor
Author
|
Maybe this pr is not really needed. But my bot suggested it during jasp-stats/jasp-desktop#6296 which works around any problems with editOptions dissappearing. There is also some commented out merge code in here somewhere. What do you think @vandenman ? |
Contributor
Author
Ive now worked around this in jasp-desktop by having a complicated reapply system. This also solves complete refreshes and stuff like that. But uncommenting the above might still be nice. It could avoid some ugliness potentially. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.