Don't crash router on malformed percent-encoded params (#3440)#4302
Open
BigBalli wants to merge 1 commit intojashkenas:masterfrom
Open
Don't crash router on malformed percent-encoded params (#3440)#4302BigBalli wants to merge 1 commit intojashkenas:masterfrom
BigBalli wants to merge 1 commit intojashkenas:masterfrom
Conversation
A URL like /search/malformed%query causes decodeURIComponent to throw URIError, which previously aborted route matching entirely and prevented the application from handling the bad URL gracefully. Catch URIError in _extractParameters and fall back to the raw, undecoded value for that parameter. The route still matches, the handler still runs, and the app can decide how to recover. Other exceptions are re-thrown unchanged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3440.
Problem
Route parameters are decoded with
decodeURIComponent, which throwsURIErrorfor malformed sequences (e.g./search/malformed%query).The exception bubbles out of
_extractParameters, aborts routematching entirely, and prevents the application from gracefully
handling a bad URL — which is especially painful for search-style
routes whose values often come from external sources.
Fix
Wrap the
decodeURIComponentcall in a try/catch in_extractParameters. OnURIError, fall back to the raw, undecodedparameter value so the route still matches and the handler still runs.
The application is then free to detect and recover (e.g. show a "bad
query" message). Other exceptions are re-thrown unchanged.
Test
Added a regression test exercising
_extractParametersdirectly witha malformed
%queryparameter.npm run lintpasses.