Fix Low Camera Resolution fix (#40)#41
Conversation
|
@DigitApps2 Thanks for the carry-over from hjam40#172 ! |
janusw
left a comment
There was a problem hiding this comment.
I can confirm that this fixes the problem from #40, as seen on the FullScreenPage of the Camera.MAUI.Test app.
However, I do feel like the fix is a bit "hacky". There is already some dedicated logic for choosing a video size here:
CameraMaui/Camera.MAUI/Platforms/Android/MauiCameraView.cs
Lines 774 to 791 in 4c88a23
I guess it would be better to fix it there than to always enforce the maximum video size.
What this method does is to choose the smallest possible video size that is bigger than the size of the CameraView. The problem of bad resolution apparently occurs if the preview is started already before the view has obtained a proper size: IMHO a more appropriate fix would be to modfiy |
No description provided.