fix(ci): front npm installs with safe-chain - #20
Merged
Conversation
tomroth
approved these changes
Aug 10, 2026
|
Approval contingent on redirecting target branch to main in the PR |
Both workflows installed dependencies unguarded. The release job holds a write-scoped GITHUB_TOKEN, so an install script in a compromised transitive dependency could publish releases from it. Adopts janetechinc/shared-actions/setup-node, which puts Aikido safe-chain on PATH before any npm invocation and installs with `npm ci --ignore-scripts`. Also bumps Node 18 -> 24 (18 is end-of-life; 24 is current LTS) and switches to `npx --no semantic-release` so a missing local install fails the job instead of silently fetching from the registry. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
ryandgood
force-pushed
the
fix/safe-chain-workflows
branch
from
August 10, 2026 19:35
c241f31 to
5c87253
Compare
|
🎉 This PR is included in version 1.5.3 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Both workflows installed dependencies unguarded. The release job holds a write-scoped
GITHUB_TOKEN, so an install script in a compromised transitive dependency could publish releases from it.janetechinc/shared-actions/setup-node, which puts Aikido safe-chain onPATHbefore any npm invocation and installs withnpm ci --ignore-scriptsnpx semantic-release→npx --no semantic-release, so a missing local install fails the job instead of silently fetching from the registryStacked on #19 (which pins
semantic-release, the dependency--nonow requires) and based on that branch, so the diff here is workflows only. Merge #19 first; this retargets tomasterautomatically.Part of the org-wide npm supply-chain remediation.
🤖 Generated with Claude Code