js/css: Animate comment insertion and deletion (fade-in/out, smooth scroll) - #1105
Open
pkvach wants to merge 1 commit into
Open
js/css: Animate comment insertion and deletion (fade-in/out, smooth scroll)#1105pkvach wants to merge 1 commit into
pkvach wants to merge 1 commit into
Conversation
pkvach
force-pushed
the
feat/animate-comment-insert-delete
branch
from
May 1, 2026 21:53
0b60e5d to
361c45e
Compare
pkvach
force-pushed
the
feat/animate-comment-insert-delete
branch
from
August 16, 2026 14:33
361c45e to
ad4a69d
Compare
Member
|
This LGTM, but probably also needs a review from somebody with more JavaScript experience. |
pkvach
force-pushed
the
feat/animate-comment-insert-delete
branch
2 times, most recently
from
August 25, 2026 22:18
125bc6b to
67f7a73
Compare
…croll) Add a lightweight animations module to animate comment insertion, reveal and removal using CSS keyframes plus a small JS helper for smooth scrolling and reliable animation end detection. Integrates into the comment insert/remove flow and respects prefers-reduced-motion. Animations are opt-in via the animations config option (default: false) and fall back to instant behaviour when disabled or unsupported. Closes isso-comments#6
pkvach
force-pushed
the
feat/animate-comment-insert-delete
branch
from
August 27, 2026 06:32
67f7a73 to
d88a168
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
CHANGES.rstbecause this is a user-facing change or an important bugfixWhat changes does this Pull Request introduce?
Add a lightweight
animationsmodule to animate comment insertion, reveal and removal using CSS keyframes plus a small JS helper for smooth scrolling and reliable animation end detection.Integrates into the comment insert/remove flow and respects
prefers-reduced-motion.Animations are opt-in via the
animationsconfig option (default: false) and fall back to instant behaviour when disabled or unsupported.How to verify:
prefers-reduced-motionto ensure animations are disabled.Why is this necessary?
Closes #6