Fix mismatch queue logic in HPCHost - #57
Merged
Merged
Conversation
The current logic only checked if the two values were not None, which would cause failure even if they both matched. Additionally, the resource acquisition logic in PBSHost always assumed queue selection from the ResourceRequestor if set and did not consider if a queue was set in the HPCHost. To fix this the queue to look for is seeded with the host queue, which is functionally None in the default case - same as before. These two fixes together work in tandem to fix issues where queue selection between two different queues since the addition of #40. The changes in #40 allowed for autoqueuing, but did not test for when there may be a deliberate selection that would differ from the auto selected queue.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current logic only checked if the two values were not None, which would cause failure even if they both matched.
Additionally, the resource acquisition logic in PBSHost always assumed queue selection from the ResourceRequestor if set and did not consider if a queue was set in the HPCHost. To fix this the queue to look for is seeded with the host queue, which is functionally None in the default case - same as before.
These two fixes together work in tandem to fix issues where queue selection between two different queues since the addition of #40. The changes in #40 allowed for autoqueuing, but did not test for when there may be a deliberate selection that would differ from the auto selected queue.