Feature/anvil message forward#2232
Open
barna-isaac wants to merge 5 commits into
Open
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2232 +/- ##
=======================================
Coverage 43.60% 43.60%
=======================================
Files 599 600 +1
Lines 25275 25286 +11
Branches 8371 8399 +28
=======================================
+ Hits 11021 11027 +6
- Misses 14197 14202 +5
Partials 57 57 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
- use the data alias - require iframeRef.current, as its abscence means the check for event source could not be performed - use user.loggedIn in the useEffect parameter, to avoid re-running the effect on a random user field changing. note we can't do the same to page as we reference the entire page object in the type check
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This forwards marking messages from the Anvil app towards the Isaac backend. This completes the work on recording answers! The PR is ready for review now, but please hold off releasing until the backend (isaacphysics/isaac-api#798) as well as config changes (https://github.com/isaacphysics/isaac-sops-config/pull/23) are merged and released. Without the backend changes, we would flood the user's screen with error messages each time they submitted an answer, although just in this one app: https://isaacscience.org/pages/app_page_mental_maths_overall.
To test this locally, apply the config and api changes locally, and visit the http://localhost:8004/pages/app_page_mental_maths_overall page. Watch out, as there is also a migration to apply. Once you've clicked submit, the answers should be recorded to your local database.