Skip to content

Improve inline cloze item alignment on Safari #2222

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jacbn wants to merge 2 commits into
base: main
Choose a base branch
from
+7 −5
Open

Improve inline cloze item alignment on Safari #2222

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
86641cd
Add sorting mechanism for total parts in Detailed Marks
jacbn Jun 22, 2026
52c5b65
Attempt to fix cloze question alignment on Safari
jacbn Jun 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/app/components/elements/markup/portals/InlineDropZones.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@ function InlineDropRegion({divId, zoneId, emptyWidth, emptyHeight, rootElement,

const draggableDropZone = <span
style={{minHeight: height, minWidth: width}}
className={classNames("d-inline-block cloze-drop-zone", !item && `rounded bg-inline-question border ${isOver ? "border-dark" : "border-light"}`)}
className={classNames("d-inline-block cloze-drop-zone align-bottom", !item && `rounded bg-inline-question border ${isOver ? "border-dark" : "border-light"}`)}
ref={setNodeRef}
>
{item
Expand Down
10 changes: 6 additions & 4 deletions src/app/components/elements/quiz/QuizProgressCommon.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -553,7 +553,9 @@ export function ResultsTablePartBreakdown({
case "name":
return (item.user?.familyName + ", " + item.user?.givenName).toLowerCase();
case "totalPartPercentage":
return -item.correctQuestionPartsCount;
case "totalAttemptedPartPercentage":
return -(item.correctQuestionPartsCount + item.incorrectQuestionPartsCount);
case "totalQuestionPercentage":
case "totalAttemptedQuestionPercentage":
return 0; // These sorts are not applicable for part breakdown
Expand Down Expand Up @@ -594,8 +596,8 @@ export function ResultsTablePartBreakdown({
{isPhy && (pageSettings?.attemptedOrCorrect === "CORRECT"
? <SortItemHeader<ProgressSortOrder>
className={classNames("correct-attempted-header narrow-header", {"sticky-ca-col": isPhy})}
defaultOrder={"totalQuestionPercentage"}
reverseOrder={"totalQuestionPercentage"}
defaultOrder={"totalPartPercentage"}
reverseOrder={"totalPartPercentage"}
currentOrder={sortOrder} setOrder={toggleSort} reversed={reverseOrder}
label={"Total correct"}
>
Expand All @@ -609,8 +611,8 @@ export function ResultsTablePartBreakdown({
</SortItemHeader>
: <SortItemHeader<ProgressSortOrder>
className={classNames("correct-attempted-header narrow-header", {"sticky-ca-col": isPhy})}
defaultOrder={"totalAttemptedQuestionPercentage"}
reverseOrder={"totalAttemptedQuestionPercentage"}
defaultOrder={"totalAttemptedPartPercentage"}
reverseOrder={"totalAttemptedPartPercentage"}
currentOrder={sortOrder} setOrder={toggleSort} reversed={reverseOrder}
label={"Total attempted"}
>
Expand Down
Loading