Freeview: Fix xmltv_ids#3103
Merged
freearhey merged 1 commit intoiptv-org:masterfrom Apr 26, 2026
Merged
Conversation
Contributor
> channels:validate
> tsx scripts/commands/channels/validate.ts sites/freeview.co.uk/freeview.co.uk.channels.xml
sites/freeview.co.uk/freeview.co.uk.channels.xml
┌─────────┬────────────────────┬──────┬───────────────────────┬───────────────┬─────────────┐
│ (index) │ type │ lang │ xmltv_id │ site_id │ name │
├─────────┼────────────────────┼──────┼───────────────────────┼───────────────┼─────────────┤
│ 0 │ 'wrong_feed_id' │ 'en' │ 'ITV1.uk@BorderPlus1' │ '64384#8360' │ 'ITV1+1' │
│ 1 │ 'wrong_channel_id' │ 'en' │ 'WildEarth.uk@SD' │ '64257#14464' │ 'WildEarth' │
│ 2 │ 'wrong_feed_id' │ 'en' │ 'WildEarth.uk@SD' │ '64257#14464' │ 'WildEarth' │
└─────────┴────────────────────┴──────┴───────────────────────┴───────────────┴─────────────┘ |
dot166
force-pushed
the
freeview-fix-xmltv_id
branch
from
91a1c84 to
18efaad
Compare
Contributor
Author
that is because those entries don't exist in the DB yet, i still need to add them |
Contributor
|
WildEarth.uk is now WildEarth.za |
Contributor
Author
thanks, will update |
dot166
force-pushed
the
freeview-fix-xmltv_id
branch
from
18efaad to
a86fde8
Compare
Contributor
Author
done |
StrangeDrVN
previously approved these changes
Apr 23, 2026
Contributor
Author
|
needs iptv-org/database#27409 |
dot166
force-pushed
the
freeview-fix-xmltv_id
branch
from
a86fde8 to
1afecda
Compare
Contributor
Author
|
the PR in the DB has been merged, this can be reviewed now |
dot166
force-pushed
the
freeview-fix-xmltv_id
branch
from
1afecda to
952d8a3
Compare
channels:validate was complaining about these
dot166
force-pushed
the
freeview-fix-xmltv_id
branch
from
952d8a3 to
6a29640
Compare
StrangeDrVN
approved these changes
Apr 24, 2026
freearhey
approved these changes
Apr 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
channels:validate was complaining about these.
it still complains about ones that are missing from the DB, i will make a PR to add them to the DB at some point, see below the results of validate before and after this PR.
before:
$ npm run channels:validate --- ./sites/freeview.co.uk/freeview.co.uk.channels.xml [14:26:57]
./sites/freeview.co.uk/freeview.co.uk.channels.xml
┌─────────┬────────────────────┬──────┬──────────────────────────────┬───────────────┬────────────────┐
│ (index) │ type │ lang │ xmltv_id │ site_id │ name │
├─────────┼────────────────────┼──────┼──────────────────────────────┼───────────────┼────────────────┤
│ 0 │ 'wrong_feed_id' │ 'en' │ 'BBCFour.uk@HD' │ '64257#18048' │ 'BBC FOUR HD' │
│ 1 │ 'wrong_feed_id' │ 'en' │ 'Channel4.uk@HD' │ '64257#17664' │ 'Channel 4 HD' │
│ 2 │ 'wrong_feed_id' │ 'en' │ 'Channel4.uk@Plus1' │ '64257#8452' │ 'Channel 4+1' │
│ 3 │ 'wrong_feed_id' │ 'en' │ 'ITV1.uk@BorderEnglandPlus1' │ '64384#8360' │ 'ITV1+1' │
│ 4 │ 'wrong_feed_id' │ 'en' │ 'ITV1.uk@HD' │ '64257#17604' │ 'ITV1 HD' │
│ 5 │ 'wrong_feed_id' │ 'en' │ 'ITV1.uk@Plus1' │ '64257#8361' │ 'ITV1+1' │
│ 6 │ 'wrong_channel_id' │ 'en' │ 'WildEarth.uk@SD' │ '64257#14464' │ 'WildEarth' │
│ 7 │ 'wrong_feed_id' │ 'en' │ 'WildEarth.uk@SD' │ '64257#14464' │ 'WildEarth' │
└─────────┴────────────────────┴──────┴──────────────────────────────┴───────────────┴────────────────┘
after:
npm run channels:validate --- ./sites/freeview.co.uk/freeview.co.uk.channels.xml [14:41:07]
(no warnings, no errors, it just doesnt display that in the output)