feat(many): migrate react-vite, vue-vite, and angular starters to Ionic v9#1880
Open
ShaneK wants to merge 6 commits into
Open
feat(many): migrate react-vite, vue-vite, and angular starters to Ionic v9#1880ShaneK wants to merge 6 commits into
ShaneK wants to merge 6 commits into
Conversation
…on-upgrades # Conflicts: # angular-standalone/base/package.json # angular/base/package.json # angular/official/sidemenu/src/app/app.component.spec.ts
brandyscarney
left a comment
brandyscarney
left a comment
Member
There was a problem hiding this comment.
This mostly looks good! But we need to make a major-9.0 branch and merge this into that. We shouldn't merge dev builds into main.
…Inbox not inbox in the same way the other test apps do it
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ionic v9 starter version upgrades
Migrates the current starters to Ionic v9 and bumps each framework's tool chain to its latest supported major in v9. Legacy starters are untouched.
react-vite:@ionic/react/@ionic/react-router: v9 dev build for now, until v9 is releasedvue-vite:@ionic/vue/@ionic/vue-router-> v9 dev buildangularandangular-standalone:@ionic/angular-> v9 dev