Skip to content

tests: relax 5s pytest-timeout marks that flake on slow CI runners #9448

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lstein merged 1 commit into from
Aug 2, 2026
Merged

tests: relax 5s pytest-timeout marks that flake on slow CI runners #9448

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions tests/app/services/model_install/test_model_install.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -686,7 +686,7 @@ def test_prune_jobs_rebind_preserves_existing_iterators(
assert all(job not in mm2_installer.list_jobs() for job in jobs)


@pytest.mark.timeout(timeout=5, method="thread")
@pytest.mark.timeout(timeout=30, method="thread")
def test_prune_jobs_waits_for_the_installer_lock(mm2_installer: ModelInstallServiceBase) -> None:
lock_held = threading.Event()
release_lock = threading.Event()
Expand Down Expand Up @@ -714,7 +714,7 @@ def _hold_lock() -> None:
assert prune_completed.is_set()


@pytest.mark.timeout(timeout=5, method="thread")
@pytest.mark.timeout(timeout=30, method="thread")
def test_import_and_wait_for_installs_fail_before_start(
mm2_app_config: InvokeAIAppConfig,
mm2_record_store,
Expand All @@ -736,7 +736,7 @@ def test_import_and_wait_for_installs_fail_before_start(
installer.wait_for_installs(timeout=0.1)


@pytest.mark.timeout(timeout=5, method="thread")
@pytest.mark.timeout(timeout=30, method="thread")
def test_import_fails_after_startup_failure(
mm2_app_config: InvokeAIAppConfig,
mm2_record_store,
Expand Down Expand Up @@ -768,7 +768,7 @@ def _fail_startup() -> None:
installer.stop()


@pytest.mark.timeout(timeout=5, method="thread")
@pytest.mark.timeout(timeout=30, method="thread")
def test_base_exception_during_startup_releases_import_waiters(
mm2_app_config: InvokeAIAppConfig,
mm2_record_store,
Expand Down
Loading