Skip to content

Attempt to fix UI coverage#12066

Open
SchrodingersGat wants to merge 42 commits into
inventree:masterfrom
SchrodingersGat:ui-coverage
Open

Attempt to fix UI coverage#12066
SchrodingersGat wants to merge 42 commits into
inventree:masterfrom
SchrodingersGat:ui-coverage

Conversation

@SchrodingersGat
Copy link
Copy Markdown
Member

@SchrodingersGat SchrodingersGat commented Jun 2, 2026

Changes

  • Split frontend tests into separate workflow file (due to increased complexity)
  • Split firefox and chromium into separate workflows

Firefox Build

  • Compiles frontend code first
  • Runs playwright tests against compiled code (on port :8000)
  • Does not run coverage

Chromium Build

  • Runs playwright tests against dev server (on port :5173)
  • Runs coverage
  • Is split into multiple shards (single shard takes over 1 hour for all our tests)

By running separate workflows for firefox and chromium we gain the following advantages:

  • Reduce run time (due to parallel workflows)
  • Test dev (5173) and prod (8000) UI code

@netlify
Copy link
Copy Markdown

netlify Bot commented Jun 2, 2026

Deploy Preview for inventree-web-pui-preview canceled.

Name Link
🔨 Latest commit abbb938
🔍 Latest deploy log https://app.netlify.com/projects/inventree-web-pui-preview/deploys/6a21846a2fc60d0008776dd0

@SchrodingersGat SchrodingersGat added CI CI / unit testing ecosystem User Interface Related to the frontend / User Interface labels Jun 2, 2026
@SchrodingersGat SchrodingersGat added this to the 1.4.0 milestone Jun 2, 2026
@SchrodingersGat
Copy link
Copy Markdown
Member Author

It would appear that changing from using compiled UI code to the vite live-load is causing the playwright tests to timeout entirely..

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request aims to improve Web UI test coverage reporting by ensuring Playwright-driven unit tests run against the instrumented (dev) UI and by explicitly uploading the generated LCOV report to Codecov.

Changes:

  • Force Playwright baseURL to the Vite dev server (http://localhost:5173) to better support collecting UI coverage.
  • Configure the QC GitHub Actions workflow to upload src/frontend/coverage/lcov.info to Codecov for the web flag.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
src/frontend/playwright.config.ts Adjusts Playwright base URL to target the Vite dev server (port 5173).
.github/workflows/qc_checks.yaml Explicitly uploads the frontend LCOV file to Codecov.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread src/frontend/playwright.config.ts Outdated
Comment thread .github/workflows/frontend.yaml Fixed
Comment thread .github/workflows/frontend.yaml Fixed
Comment thread src/frontend/playwright.config.ts Outdated
Comment thread .github/workflows/frontend.yaml Outdated
Comment thread .github/workflows/frontend.yaml Outdated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CI CI / unit testing ecosystem User Interface Related to the frontend / User Interface

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants