Attempt to fix UI coverage#12066
Open
SchrodingersGat wants to merge 42 commits into
Open
Conversation
✅ Deploy Preview for inventree-web-pui-preview canceled.
|
Member
Author
|
It would appear that changing from using compiled UI code to the vite live-load is causing the playwright tests to timeout entirely.. |
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request aims to improve Web UI test coverage reporting by ensuring Playwright-driven unit tests run against the instrumented (dev) UI and by explicitly uploading the generated LCOV report to Codecov.
Changes:
- Force Playwright
baseURLto the Vite dev server (http://localhost:5173) to better support collecting UI coverage. - Configure the QC GitHub Actions workflow to upload
src/frontend/coverage/lcov.infoto Codecov for thewebflag.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
src/frontend/playwright.config.ts |
Adjusts Playwright base URL to target the Vite dev server (port 5173). |
.github/workflows/qc_checks.yaml |
Explicitly uploads the frontend LCOV file to Codecov. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- use test sharding - Only upload coverage on master
matmair
reviewed
Jun 3, 2026
matmair
reviewed
Jun 3, 2026
matmair
reviewed
Jun 3, 2026
matmair
approved these changes
Jun 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Firefox Build
Chromium Build
By running separate workflows for firefox and chromium we gain the following advantages: