fix: exclude revision family from duplicate IPN check#12020
Open
bvweerd wants to merge 1 commit into
Open
Conversation
When PART_ALLOW_DUPLICATE_IPN is False, saving a revision that shares the same IPN as its parent incorrectly raised a "Duplicate IPN not allowed" error. Revisions of the same part are expected to share the same IPN, so they must be excluded from the uniqueness check. Fixes inventree#12017
✅ Deploy Preview for inventree-web-pui-preview canceled.
|
Member
|
The |
Author
|
But how is it then that you're allowed to make a revision item with the same IPN, although the allow duplicate IPN is false, but not unlock the part? Looking at the code in validate_unique(), the model itself already has a check (line 1053) that explicitly allows the same IPN across different revisions, as long as the combination of Name + IPN + Revision is unique: This check implicitly permits two parts to share the same IPN as long as their revision differs. Also referring to #1112 (comment) |
Member
|
IMO: unique means unique; not unique together with another key |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When PART_ALLOW_DUPLICATE_IPN is False, saving a revision that shares the same IPN as its parent incorrectly raised a "Duplicate IPN not allowed" error. Revisions of the same part are expected to share the same IPN, so they must be excluded from the uniqueness check.
Fixes #12017