feat(backend): add throtteling by default#11951
Open
matmair wants to merge 6 commits into
Open
Conversation
matmair
added
api
✅ Deploy Preview for inventree-web-pui-preview canceled.
|
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #11951 +/- ##
==========================================
- Coverage 91.29% 91.28% -0.01%
==========================================
Files 971 971
Lines 51255 51263 +8
==========================================
+ Hits 46792 46796 +4
- Misses 4463 4467 +4
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
Member
|
Any testing we can apply to this? |
Member
|
I also wonder whether these limits are sufficient for loading 2-3 pages simultaneously? A page load can throw a few requests to the server, this should be tested thoroughly with some abusive page loads. |
Member
Author
|
I will look into testing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of SAST / AI-driven vuln discovery was how trivial some API points are to DoS attack (unknowingly even when using an MCP); while these limits are too lax for small instances they should keep the impact on most instances minimal while providing a good first barrier.
As I already mentioned in the threat model: a WAF is much better solution to this but most instances on the internet seem to not use that.