fix(backend): registry install command#11657
Conversation
✅ Deploy Preview for inventree-web-pui-preview canceled.
|
|
@vrzh can you qualify if this solves your issue? |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #11657 +/- ##
==========================================
+ Coverage 86.57% 91.49% +4.91%
==========================================
Files 1385 979 -406
Lines 88870 52449 -36421
Branches 9954 0 -9954
==========================================
- Hits 76943 47989 -28954
+ Misses 11865 4460 -7405
+ Partials 62 0 -62
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
…matmair/issue11460
…Tree into matmair/issue11460
I am not sure what is the correct way to fill out the InvenTree UI, what are the correct values for "Package Name" and "Source URL". In my original bug report, I have 3 options, is the first one correct? Package Name: "my_custom_plugin" |
|
That is a difficult question. Anything pip will resolve works - that can be a local package, an http/https repository, any number of vcs repositories. The option you listed should work. |
What is a quick way of testing this branch please, ideally through docker? Sorry, I am not very familiar with Inventree dev setup. I saw here https://docs.inventree.org/en/latest/start/docker/#tagged-images that you can get the latest main using |
|
@matmair pushing this to the next release, hoping to get the 1.3.0 out soon |
|
@vrzh we are not releasing docker-images for PRs; you would need a dev setup or build the branch locally; are you able to do that? |
Hi, sorry for the delay, it took a while to follow the devcontainer instructions for the first time and getting it working. I think the fix works great, at least I now get the "Plugin installed successfully" toast message. Now I need to work on my plugin :) FYI I now use the following:
Which is what I would have expected to work - so that is great. In the future I will also test specifying an exact version to install. |
…matmair/issue11460
…matmair/issue11460
Fixes problems with installing from custom indexes
Also cleans up logic a bit to be easier to understand
Fixes #11460