Enable translations

[SarahW91]

Description

I think it would be beneficial to enable translations for this module. There are some rather prominent components, e.g. EmptyResults that can't be translated otherwise.

Adding the necessary scripts and dependencies adds this ability, e.g.:

What do you think? If you are generally okay with this, I'll start marking all strings in the module as translatable.

Checklist

• I'm aware of the code of conduct.
• I've created logical separate commits and followed the commit message format.
• I've identified the copyright holder(s) and updated copyright headers for touched files (>15 lines contributions).
• I've NOT included third-party code (copy/pasted source code or new dependencies).
  • If you have added third-party code (copy/pasted or new dependencies), please reach out to an architect on Discord.

[Samk13]

Thanks for this @SarahW91! this is a nice addition, enabling translations definitely makes sense.

Before merging, I'd prefer we align this a bit more with what we already have in invenio-app-rdm:

• use the more recent compileCatalog.js pattern (async/await, proper error handling, normalized output, etc..),
• generate the translations index (like _generatedTranslations.js) instead of maintaining messages/index.js manually.

This will keep things consistent across packages and avoid extra maintenance later on.

[Samk13]

Could we align the scripts with the implementation we already use in invenio-app-rdm? https://github.com/inveniosoftware/invenio-app-rdm/blob/master/invenio_app_rdm/theme/assets/semantic-ui/translations/invenio_app_rdm/scripts/compileCatalog.js

[Samk13]

Same here, check the PR: inveniosoftware/invenio-app-rdm@13c1490#diff-8b01847cace59a05dffd86a564f110ec278d9f3913752994b04ed6c42ec72add

[SarahW91]

What I don't quite get is where the *.po files and language configs are coming from. Are they pulled from Transifex? because there seems to be no step to automatically generate them otherwise

[Samk13]

Yes, without Transifex yet, the new language has to be bootstrapped locally first.

In the current Invenio setup, init_catalog only adds the language to package.json; it does not create the .po file automatically.
Then extract_messages updates the extracted JSON and generates the English source files (translations.pot / messages/en/messages.po).
For any additional language, you still need to create messages//messages.po locally first, and only then compile_catalog can convert it to translations.json.

So the local dev flow is basically:

npm run init_catalog lang <lang>
npm run extract_messages # create/bootstrap messages/<lang>/messages.po
npm run compile_catalog lang <lang>

Once Transifex is set up, that manual step (dev work) gets replaced by pulling the .po files from Transifex.

It makes me wonder where all these languages listed in this PR are coming from. Were they generated automatically, or are they copied manually from another package?

[SarahW91]

I copied those over from https://github.com/inveniosoftware/react-invenio-deposit