Skip to content

make ready for rspack - #26

Closed
utnapischtim wants to merge 4 commits into
inveniosoftware:masterfrom
utnapischtim:make-ready-for-rspack
Closed

make ready for rspack#26
utnapischtim wants to merge 4 commits into
inveniosoftware:masterfrom
utnapischtim:make-ready-for-rspack

Conversation

@utnapischtim

Copy link
Copy Markdown
Contributor
  • context: make the bundle current_app unaware
  • pnpm: add override for pnpm
  • project: remove current_app usage

@utnapischtim
utnapischtim marked this pull request as ready for review February 20, 2025 08:10
* it is possible to choose between npm and pnpm over the configuration
  variable JAVASCRIPT_PACKAGES_MANAGER. to be backward compatible npm is
  the default package manager.
* this makes it possible to reduce usage of current_app and enables
  performance boosts on invenio-cli
@utnapischtim

utnapischtim commented Mar 1, 2025

Copy link
Copy Markdown
Contributor Author

the change to use app instead of current_app was made to use the classes in invenio-cli directly. The approach of using the classes directly had a massive drawback (invenio-cli was not usable if installed globally). so invenio-cli has been changed. a new approach has been implemented here which doesn't need the app in the classes any more. this means that only this particular commit is really necessary.

it could be that the whole change of this PR could be helpful in the future but it isn't necessary at the moment!

even further thought: we could move that functionality to pywebpack. here. it wouldn't be possible to use current_app in pywebpack but we could read the variable from os.environ and that could be also set in invenio-cli or on a docker image build as environment variable.

if those reverts will be done, the reverts described here in invenio-assets have to be applied too.

@utnapischtim

Copy link
Copy Markdown
Contributor Author

superseded by #27

@utnapischtim
utnapischtim deleted the make-ready-for-rspack branch April 29, 2025 19:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant