feat: update PNPM version handling in Dockerfile

[Samk13]

❤️ Thank you for your contribution!

Description

• Use ARG for PNPM_VERSION to allow dynamic versioning
• Update npm install command to reference PNPM_VERSION

Checklist

Ticks in all boxes and 🟢 on all GitHub actions status checks are required to merge:

• I'm aware of the code of conduct.
• I've created logical separate commits and followed the commit message format.
• I've added relevant test cases.
• I've added relevant documentation.
• I've marked translation strings.
• I've identified the copyright holder(s) and updated copyright headers for touched files (>15 lines contributions).
• I've NOT included third-party code (copy/pasted source code or new dependencies).
  • If you have added third-party code (copy/pasted or new dependencies), please reach out to an architect on Discord.

Frontend

• I've followed the CSS/JS and React guidelines.
• I've followed the web accessibility guidelines.
• I've followed the user interface guidelines.

Reminder

By using GitHub, you have already agreed to the GitHub’s Terms of Service including that:

1. You license your contribution under the same terms as the current repository’s license.
2. You agree that you have the right to license your contribution under the current repository’s license.

[fenekku]

We would need to adapt invenio-cli to pass down the appropriate INVENIO_WEBPACKEXT_NPM_PKG_CLS to make sure things are coherent. But it's the right idea 👍

[fenekku]

👍

[fenekku]

And then on invenio-cli side we can inject WEBPACKEXT_NPM_PKG_CLS .

[fenekku]

Thanks for identifying these non-obvious behaviours @Samk13! I am happy to merge Friday morning (or you can when you feel appropriate).

[utnapischtim]

@fenekku

invenio-cli handles this already

https://github.com/inveniosoftware/invenio-cli/blob/d76ea66462f63905015007370be09555d156a2b5/invenio_cli/helpers/package_managers.py#L234

with javascript_package_manager in .invenio you can configure npm vs pnpm.

there is also the variable python_package_manager for uv

and rspack is configured over WEBPACKEXT_PROJECT in invenio.cfg for the sake of completeness

and inveniosoftware/invenio-cli#385 explains why rspack is configured in invenio.cfg and not in .invenio

[Samk13]

Reading through the pnpm docs, it looks like we could potentially simplify this Dockerfile further by relying on pnpm runtime set node <version> -g to install Node.js as well.

Since we're already standardizing on pnpm, that could let us drop the NodeSource setup and the nodejs/npm apt packages entirely, and have pnpm manage both the package manager and runtime versions.

Might be worth exploring in a follow-up if it aligns with our support and deployment expectations.

WDYT @fenekku @utnapischtim?

[fenekku]

@Samk13 Interesting 🤔 . I made a ticket for that: #98 so we can investigate after v14 release.