Skip to content

fix: add core.json to package.json exports#14

Open
SimenB wants to merge 1 commit intoinspect-js:mainfrom
SimenB:patch-1
Open

fix: add core.json to package.json exports#14
SimenB wants to merge 1 commit intoinspect-js:mainfrom
SimenB:patch-1

Conversation

@SimenB
Copy link
Copy Markdown

@SimenB SimenB commented Jul 24, 2023

Allows browserify/resolve@122bb64 to be just require('is-core-module/core.json')

@codecov
Copy link
Copy Markdown

codecov bot commented Jul 24, 2023

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.47%. Comparing base (77d33fb) to head (83cb795).
⚠️ Report is 24 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #14   +/-   ##
=======================================
  Coverage   90.47%   90.47%           
=======================================
  Files           1        1           
  Lines          42       42           
  Branches       17       17           
=======================================
  Hits           38       38           
  Misses          4        4           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@ljharb
Copy link
Copy Markdown
Member

ljharb commented Jul 24, 2023

While this is certainly a technically viable resolution for resolve, I am very very very loath to add to the exposed API of is-core-module.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants