feat(open-knowledge): enable external link hover previews by default (#2695)#659
Merged
Conversation
…(#2695) * feat(open-knowledge): enable external link hover previews by default External link previews shipped off by default (opt-in), which made the feature undiscoverable. Flip the linkPreviews.enabled default to on so external hover cards appear out of the box, and keep the Settings toggle as a per-machine opt-out. Both gates key off the schema default: the client reads the resolved project-local config and the server reads it via readConfigSafely, which degrades to schema defaults, so flipping the default flips real behavior end to end. The project-local scope is preserved, so a committed/shared config still cannot set another machine's egress, and an explicit linkPreviews.enabled: false still opts out. The SSRF guard, anti-proxy gating, no-credentials fetch, local cache, and silent fallback to the URL pill are unchanged; internal doc previews remain always-on and local-only. * address local review for link-preview default flip - server: fail closed on a degraded project-local config read so an explicit linkPreviews.enabled: false opt-out is never silently reverted to egress-ON by config corruption (only a genuinely-absent config inherits the on-by-default schema value) - test: pin absent-config -> previews-enabled at the readConfigSafely layer - schema: note why link previews default ON while search.semantic defaults OFF - docs: surface the packaged-desktop limitation in a callout under the on-by-default line, not buried in the opt-out paragraph; changeset too - comments: align three adjacent opt-in references with the new default GitOrigin-RevId: ff73e72feed7afcc5529103b5fe0d6bf1184dc60
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Copybara-translated 1 Inkeep OSS change. Rebase-merge this PR so the prepared commit lands directly on public main.