Skip to content

chore(frontend): drop emotion - #3998

Merged
Kadrian merged 1 commit into
refactor/tailwind-entity-historyfrom
chore/drop-emotion
Sep 2, 2026
Merged

chore(frontend): drop emotion#3998
Kadrian merged 1 commit into
refactor/tailwind-entity-historyfrom
chore/drop-emotion

Conversation

@Kadrian

@Kadrian Kadrian commented Sep 2, 2026

Copy link
Copy Markdown
Collaborator

Emotion → tailwind migration, PR 6/6: emotion is gone.

(stacked on #3997, stack overview in #3992 — must land together with the downstream mirror, see below)

Main change

  • @emotion/react, @emotion/styled, @emotion/is-prop-valid removed from deps; jsxImportSource gone from vite + tsconfig
  • conquery({ theme }) now takes the slim AppTheme{ img: { logo, logoWidth, logoBackgroundSize, spinner }, palette }. All colours/fonts/radii live in index.css @theme (downstream overrides them via :root)
  • app-theme.ts shrinks accordingly; the Theme module augmentation in react-app-env.d.ts is deleted; storybook provides AppThemeContext instead of ThemeProvider

Downstream

  • the mirror PR (deps −3, its app-theme.ts now { img, palette }, vite jsxImportSource removal) must merge together with the submodule bump to this commit — the old conquery({ theme }) call shape no longer compiles

Checks: biome, tsc, vitest, vite build and storybook build green; zero @emotion references left.

conquery({ theme }) now takes only { img, palette }; downstream repo must mirror app-theme, vite config and deps
@Kadrian
Kadrian merged commit 2412e61 into develop Sep 2, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants