Skip to content

Docs/update adr docs - #436

Merged
halcwb merged 2 commits into
informedica:masterfrom
halcwb:docs/update-adr-docs
Aug 4, 2026
Merged

Docs/update adr docs#436
halcwb merged 2 commits into
informedica:masterfrom
halcwb:docs/update-adr-docs

Conversation

@halcwb

@halcwb halcwb commented Aug 4, 2026

Copy link
Copy Markdown
Collaborator

Update ADR docs by removing documentation that describes resource specs. This now is just code, code comments and/or tests. Addressing issue #411

Also, add some documentation how to upgrade the URL params.

This is an ongoing effort to clean up the documentation for this repository as mentioned in #411

@greptile-apps

greptile-apps Bot commented Aug 4, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

This PR relocates spreadsheet resource specifications from ADR documents into source comments and executable column-contract tests, and adds roadmap documentation for URL-parameter and patient-persistence upgrades.

  • Documents GenFORM sheet DTOs, parsers, and resource relationships alongside the implementation.
  • Adds contract tests covering required and tolerated columns for ten resource sheets.
  • Removes superseded resource-requirement and verification ADRs and updates repository guidance.
  • Adds design proposals for expanded EHR URL parameters and patient persistence.

Confidence Score: 5/5

The PR appears safe to merge because its production-source changes are documentation or behavior-preserving mapper extractions, and the new tests match the current parser contracts.

No changed-code-triggered runtime, build, data-integrity, or security failure remains after checking the extracted mapper signatures, resource column declarations, fixture usage, and the explicitly prospective URL migration documentation.

Important Files Changed

Filename Overview
src/Informedica.GenFORM.Lib/Types.fs Adds extensive resource-schema and field-semantics documentation without changing runtime data shapes.
src/Informedica.GenFORM.Lib/Mapping.fs Extracts existing row-mapping lambdas into testable named functions while preserving behavior and call signatures.
tests/Informedica.GenFORM.Tests/Tests.fs Adds column-contract coverage whose declared required and tolerated columns align with current parser access patterns.
docs/roadmap/feature-ehr-url-parameters.md Documents a proposed three-letter URL parameter migration and clearly identifies the parser and model changes still required.
docs/roadmap/feature-patient-persistence.md Adds a design proposal for persisting patient context without altering current runtime behavior.
src/Informedica.GenFORM.Lib/DoseRuleData.fs Documents parser optionality and the known pre-existing omission of Loc from CSV emission.

Reviews (1): Last reviewed commit: "chore: merge with docker build target" | Re-trigger Greptile

@halcwb
halcwb merged commit 939aec7 into informedica:master Aug 4, 2026
12 checks passed
@halcwb
halcwb deleted the docs/update-adr-docs branch August 4, 2026 07:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant