fix(deps): decouple Build target from RestoreClient/Clean dependency chain - #426
Merged
Merged
Conversation
…chain Is the commented-out server watch-test line in WatchTests (Build.fs:244, `dotnet [ "watch"; "run"; "--no-restore" ] serverTestsPath`) abandoned, or still intended to be finished? If it's abandoned, we can drop WatchTests's dependency on Build too, it only runs the client Fable/Vite watcher, so nothing in it currently needs a server build. If it's not dead, then we can to leave the Build dependency in place as it is in this PR, so it's still there when that line gets uncommented and adressed.
Contributor
Greptile SummaryThis PR decouples server builds from the client restore/clean chain.
Confidence Score: 4/5The PR appears safe to merge, with a non-blocking documentation update needed to reflect the new dependency graph. The affected targets retain their required transitive prerequisites, but DEVELOPMENT.md still presents the replaced linear target chains. Files Needing Attention: Build.fs and DEVELOPMENT.md Important Files Changed
Flowchart%%{init: {'theme': 'neutral'}}%%
flowchart LR
Clean --> RestoreClient
RestoreClient --> Bundle
Build --> Run
RestoreClient --> Run
Build --> TestHeadless
RestoreClient --> TestHeadless
Build --> WatchTests
RestoreClient --> WatchTests
Build --> ServerTests
Build --> CheckVersions
Reviews (1): Last reviewed commit: "fix(deps): decouple Build target from Re..." | Re-trigger Greptile |
…t graph Build.fs's target graph was split into independent Build and RestoreClient parts in the previous commit, but DEVELOPMENT.md's dependency diagram and the Run target's prose description still showed the old linear chain. Update both to match, and add ServerTests/CheckVersions to the diagram. Addresses Greptile review feedback on PR informedica#426.
halcwb
approved these changes
Jul 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@halcwb
Is the commented-out server watch-test line in WatchTests (Build.fs:244,
dotnet [ "watch"; "run"; "--no-restore" ] serverTestsPath) abandoned, or still intended to be finished?If it's abandoned, we can drop WatchTests's dependency on Build too, it only runs the client Fable/Vite watcher, so nothing in it currently needs a server build.
If it's not dead, then we can to leave the Build dependency in place as it is in this PR, so it's still there when that line gets uncommented and addressed.
Partially addresses point 5 in #387