[3.0] Fix React useForm submitting stale data after synchronous setData#3057
Open
skryukov wants to merge 1 commit intoinertiajs:3.xfrom
Open
[3.0] Fix React useForm submitting stale data after synchronous setData#3057skryukov wants to merge 1 commit intoinertiajs:3.xfrom
useForm submitting stale data after synchronous setData#3057skryukov wants to merge 1 commit intoinertiajs:3.xfrom
Conversation
useForm submitting stale data after synchronous setDatauseForm submitting stale data after synchronous setData
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the React adapter, calling
setData()(orreset()) and then immediately submitting the form in the same event handler submits the pre-update data, not the value just written.Root cause:
submit()reads form data fromdataRef.current, butdataRefis only refreshed inside a post-commituseEffect. Vue and Svelte are unaffected.See inertiajs/inertia-rails#300