Do not alter boolean settings#248
Open
mardukbp wants to merge 1 commit into
Open
Conversation
Negating the value of a boolean setting when retrieving its value makes it difficult to reason about its meaning.
indygreg
force-pushed
the
main
branch
17 times, most recently
from
May 10, 2020 20:24
48fe3a7 to
48a4cab
Compare
indygreg
force-pushed
the
main
branch
10 times, most recently
from
November 22, 2020 20:53
0219dd5 to
860114e
Compare
indygreg
force-pushed
the
main
branch
25 times, most recently
from
November 23, 2020 01:46
296b083 to
13e08f6
Compare
indygreg
force-pushed
the
main
branch
3 times, most recently
from
December 1, 2021 03:16
8f998b7 to
5c5ac33
Compare
indygreg
force-pushed
the
main
branch
2 times, most recently
from
May 31, 2022 04:07
5e0524b to
789c62e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Negating a boolean setting when retrieving its value makes it difficult to reason about its meaning.