ci: align pytorch version requirements in wheel build#99
Open
tongke6 wants to merge 4 commits into
Open
Conversation
The nvidia/cuda devel container images include the CUDA toolkit but not cuDNN. When torch is installed via pip, nvidia-cudnn-cu12 (and friends) land in site-packages/nvidia/*/lib/, which is not on the system library search path. This causes an ImportError for libcudnn.so.9 when the build backend tries to import torch. Add a step that discovers all PyTorch and NVIDIA pip package library directories and appends them to LD_LIBRARY_PATH via GITHUB_ENV, with a validation check that libcudnn.so.9 is actually found.
Verified working in CI — drop debug logging, redundant validation, and heredoc in favor of a compact inline python -c one-liner.
The previous 1-liner broke because single quotes inside $(python3.12 -c '...') conflicted with the outer shell quoting. Switch to a heredoc (<<'EOF') for the Python snippet, which avoids nested quoting entirely and keeps the code readable.
Contributor
|
Note Gemini is unable to generate a review for this pull request due to the file types involved not being currently supported. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📌 Description
ci: align pytorch version requirements in wheel build
🔍 Related Issues
#83
🚀 Pull Request Checklist
Thank you for contributing to cuLA! Before we review your pull request, please make sure the following items are complete.
✅ Pre-commit Checks
pre-commitby runningpip install pre-commit(or used your preferred method).pre-commit install.pre-commit run --all-filesand fixed any reported issues.🧪 Tests
⚡ Performance
Reviewer Notes