Add `--all-features`, `cargo fmt --check`, `cargo check`, `cargo test`, `cargo doc`, and `RUSTFLAGS=-Dwarnings` to CI#483

Merged

kkysen merged 24 commits into

masterfrom

kkysen/stricter-ci

Aug 9, 2022

Commits on Jul 20, 2022

Added `--all-features`, `cargo test`, and `cargo doc` to CI.
kkysen
committed
Added `./scripts/check.sh` to easily locally test if you pass the new CI checks.
kkysen
committed
Added all the tests to `azure-pipelines.yml`, but with `cargo test` and `cargo clippy` commented out as they currently don't work yet.
kkysen
committed
Enable `cargo test` on Darwin as that appears to be working.
kkysen
committed
Added a separate `cargo check` step as we're not running `cargo clippy` yet.
kkysen
committed
Disabling `--all-features` as that might be causing things to link against different LLVM libraries/versions, which may cause the errors I'm seeing?
kkysen
committed
Moved `cargo doc` to the end as it takes longer than the tests and is probably less likely to have an important failure.
kkysen
committed
Trying to re-enable `cargo test` with `--all-features` on Linux now that it works again (though the `--all-features` might fail).
kkysen
committed
Don't use `--all-features` with `cargo test` on Arch/Fedora, as that breaks, too.
kkysen
committed
Specify `--features dynamic-instrumentation` instead of `--all-features` for commands that run (`cargo build`, `cargo test`) as we don't want `--features llvm-static` in those cases.
kkysen
committed
`test_translator.py` and `pdg.sh` were inheriting the `RUSTFLAGS=-Dwarnings` from `check.sh` causing them to fail, so now `unset RUSTFLAGS` before them. Now `check.sh` passes. Also, build with `-…
kkysen
committed
Add `--tests` to `cargo check` like it is for `cargo clippy` (though currently commented out).
kkysen
committed
Removed `--all` from `cargo clippy` as `cargo check --help` says it's deprecated.
kkysen
committed
Renamed `check.sh` to `run_ci_checks.sh` to be more descriptive.
kkysen
committed
Added inline documentation to `run_ci_checks.sh`.
kkysen
committed
Added mostly the same inline documentation to `azure-pipelines.yml`.
kkysen
committed
`brew install bash` on macOS/Darwin, as it's by default bash 3, which doesn't support arrays properly.
kkysen
committed

Commits on Aug 4, 2022

Merge branch 'master' into kkysen/stricter-ci
kkysen
committed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add `--all-features`, `cargo fmt --check`, `cargo check`, `cargo test`, `cargo doc`, and `RUSTFLAGS=-Dwarnings` to CI#483

Add `--all-features`, `cargo fmt --check`, `cargo check`, `cargo test`, `cargo doc`, and `RUSTFLAGS=-Dwarnings` to CI#483
kkysen merged 24 commits into
masterfrom
kkysen/stricter-ci

Commits on Jul 20, 2022

Added `--all-features`, `cargo test`, and `cargo doc` to CI.

Added `./scripts/check.sh` to easily locally test if you pass the new CI checks.

Added all the tests to `azure-pipelines.yml`, but with `cargo test` and `cargo clippy` commented out as they currently don't work yet.

Enable `cargo test` on Darwin as that appears to be working.

Added a separate `cargo check` step as we're not running `cargo clippy` yet.

Disabling `--all-features` as that might be causing things to link against different LLVM libraries/versions, which may cause the errors I'm seeing?

Moved `cargo doc` to the end as it takes longer than the tests and is probably less likely to have an important failure.

Trying to re-enable `cargo test` with `--all-features` on Linux now that it works again (though the `--all-features` might fail).

Don't use `--all-features` with `cargo test` on Arch/Fedora, as that breaks, too.

Specify `--features dynamic-instrumentation` instead of `--all-features` for commands that run (`cargo build`, `cargo test`) as we don't want `--features llvm-static` in those cases.

`test_translator.py` and `pdg.sh` were inheriting the `RUSTFLAGS=-Dwarnings` from `check.sh` causing them to fail, so now `unset RUSTFLAGS` before them. Now `check.sh` passes. Also, build with `-…

Add `--tests` to `cargo check` like it is for `cargo clippy` (though currently commented out).

Removed `--all` from `cargo clippy` as `cargo check --help` says it's deprecated.

Renamed `check.sh` to `run_ci_checks.sh` to be more descriptive.

Added inline documentation to `run_ci_checks.sh`.

Added mostly the same inline documentation to `azure-pipelines.yml`.

`brew install bash` on macOS/Darwin, as it's by default bash 3, which doesn't support arrays properly.

Commits on Aug 4, 2022

Merge branch 'master' into kkysen/stricter-ci

Commits on Aug 9, 2022

Merge branch 'master' into kkysen/stricter-ci

Removed `--features dynamic-instrumentation` from CI checks as it has now been removed.

Specified `--no-deps` for `cargo doc` as we just want to check, not build documentation.

De-duplicate ci checks in `azure-pipelines.yml` and `run_ci_checks.sh` and force them to be in sync.

Moved `cargo doc` to after `cargo check` as now it's much faster (with `--no-deps`) so pushing it to the end (since it's less likely to fail) isn't that important.

Exclude `c2rust-analyze` from `cargo test` in CI as it's broken on some OSes (https://github.com/immunant/c2rust/issues/593) and we want things to work now.