Skip to content

avoid duplicates in split view #612

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Qoen1 wants to merge 4 commits into from
Closed

avoid duplicates in split view #612

Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
d92cc1c
added
Mar 25, 2026
44d7246
removed code comments and logging
Mar 25, 2026
5060b03
try to find different image in backlog instead of just removing dupli…
Mar 27, 2026
5a31562
removed next.splice to avoid unexpected side effects
Mar 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 23 additions & 1 deletion immichFrame.Web/src/lib/components/home-page/home-page.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -180,7 +180,10 @@
}

const useSplit = shouldUseSplitView(assetBacklog);
const next = assetBacklog.splice(0, useSplit ? 2 : 1);
let next = assetBacklog.splice(0, useSplit ? 2 : 1);

next = removeDuplicateFromNextAssets(next);

assetBacklog = [...assetBacklog];

if (displayingAssets.length) {
Expand All @@ -196,6 +199,25 @@
assetsState = await pickAssets(next);
}

function removeDuplicateFromNextAssets(next: api.AssetResponseDto[]): api.AssetResponseDto[]{
if(isDuplicate(next)){
return next.slice(0,1);
}
return next;
}

function isDuplicate(next: api.AssetResponseDto[]): boolean{
const seen = new Set<string>();

for(const item of next){
if(seen.has(item.id)){
return true;
}
seen.add(item.id);
}
return false;
}

async function getPreviousAssets() {
if (!assetHistory.length) {
return;
Expand Down