Skip to content

Check valid python more strictly in shell entry point #258

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
syjung6967 wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Check valid python more strictly in shell entry point #258

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3d2204b
Less indent and check valid python more strictly
syjung6967 May 18, 2021
73b6c04
check all executable files in one line
syjung6967 May 18, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 7 additions & 16 deletions guider/guider
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
#!/usr/bin/env bash

@iipeace iipeace May 19, 2021

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why did you restrict the shell to bash?
It will cause error on systems without bash.
There are also various shells such as dochsh, dash, rbash, rsh...


# Guider Launcher
#
# Copyright (c) 2016-2021 Peace Lee <iipeace5@gmail.com>
Expand All @@ -7,23 +9,12 @@
# Software Foundation; either version 2 of the License, or (at your option)
# any later version.

# check python #
if [ ! $PYTHON ]
# check valid Python in order: user-specified, python, python3 and 2 #
PYTHON=`which $PYTHON || which python || which python3 || which python2`

@iipeace iipeace May 19, 2021

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks nice! :)

if [ z`$PYTHON -V 2>/dev/null | cut -d' ' -f1` != "zPython" ]

@iipeace iipeace May 19, 2021

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about using regular expressions instead of external commands like cut?

then
PYTHON=$(which python)
if [ ! $PYTHON ]
then
PYTHON=$(which python3)
if [ ! $PYTHON ]
then
PYTHON=$(which python2)
if [ ! $PYTHON ]
then
echo "[Error] fail to find python"
exit
fi
fi
fi
echo "[Error] fail to find python"
exit
fi

# export CMDLINE for Guider #
Expand Down