fix: prevent keyboard relative speed baseline reset after tab idle#1495
Open
MuizNadeem wants to merge 1 commit intoigrigorik:masterfrom
Open
fix: prevent keyboard relative speed baseline reset after tab idle#1495MuizNadeem wants to merge 1 commit intoigrigorik:masterfrom
MuizNadeem wants to merge 1 commit intoigrigorik:masterfrom
Conversation
Author
|
Hi @igrigorik, could you please review this PR? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1494
Summary
This PR fixes a regression where keyboard relative speed shortcuts (
s/d) could apply from a1.0xbaseline after tab backgrounding, instead of from the active/effective remembered speed.Changes
1.0speed as baseline for the first relative step when:1.0, andsource: 'init') in media event restore path.lastSpeedforsource: 'init'updates.Why
Lifecycle/init reconciliation should restore playback without mutating user-authoritative remembered speed. If lifecycle restore writes
lastSpeed, first keyboard relative adjustment can compute from an incorrect1.0baseline after idle/background transitions.Test Plan
1.0.lastSpeed.rememberSpeed1.8xd/s1.9x/1.7x(not1.1x/0.9x)