Skip to content

fix: Include figure prefix in name before rendering text#966

Draft
kesara wants to merge 4 commits into
ietf-tools:mainfrom
kesara:fix/text-wrap-issue-2
Draft

fix: Include figure prefix in name before rendering text#966
kesara wants to merge 4 commits into
ietf-tools:mainfrom
kesara:fix/text-wrap-issue-2

Conversation

@kesara

@kesara kesara commented Feb 2, 2023

Copy link
Copy Markdown
Member

Fixes ##961

@cabo

cabo commented Feb 2, 2023

Copy link
Copy Markdown
Contributor

Is the same fix needed for all the other uses of .tjoin()?
If not, why not?

@kesara kesara marked this pull request as draft February 2, 2023 20:07
@kesara

kesara commented Feb 2, 2023

Copy link
Copy Markdown
Member Author

Is the same fix needed for all the other uses of .tjoin()? If not, why not?

tjoin() is used to render reference, references -> name, section -> name, table -> name.
I'll experiment and see if this fix is adversely affecting any of those.

@cabo

cabo commented Feb 2, 2023

Copy link
Copy Markdown
Contributor

I'll experiment and see if this fix is adversely affecting any of those.

I just thought that they may have the same bug that Alice reported (line-breaking hyphens and putting them back together with a superfluous space), which would need to be fixed in a similar way.

@kesara kesara force-pushed the fix/text-wrap-issue-2 branch from 6365b94 to 1924291 Compare August 31, 2023 04:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants