feat: withdraw doc #1356
Conversation
|
| <BaseButton | ||
| v-if="props.rfcToBe?.disposition === 'in_progress'" | ||
| @click="isWithdrawDialogShown = true" | ||
| class="flex items-center !bg-rose-600 hover:!bg-rose-500" |
There was a problem hiding this comment.
can you use btn-type prop (mapped to classForBtnType) rather than these one-off styles?
|
|
||
| const props = defineProps<Props>() | ||
| const emit = defineEmits<{ assignmentsChanged: [] }>() | ||
| const emit = defineEmits<{ assignmentsChanged: []; withdrawn: [] }>() |
There was a problem hiding this comment.
Is the type really an empty array or will it have a length during runtime?
afaik emits have broadcasters and receivers so it's probably worth having a shared type on both ends, from a utils file
| </div> | ||
| </div> | ||
| <div class="bg-gray-50 dark:bg-neutral-800 px-4 py-3 sm:flex sm:flex-row-reverse sm:px-6 gap-2"> | ||
| <button |
There was a problem hiding this comment.
Any reason not to use BaseButton for these?
|
|
||
| // Withdraw committed — the comment is a best-effort annotation. | ||
| try { | ||
| if (comment.value.trim()) { |
There was a problem hiding this comment.
use a tmp var for this trimmed value so it doesn't get out of sync with the duplicate trimmed value?
| <Icon v-if="isSubmitting" name="ei:spinner-3" size="1.1em" class="animate-spin mr-1" /> | ||
| Withdraw | ||
| </button> | ||
| <button type="button" class="btn-secondary" :disabled="isSubmitting" @click="cancel">Cancel</button> |
There was a problem hiding this comment.
If the screenshot is still accurate then perhaps we might need more spacing between the cancel and withdraw buttons? Obv don't want people clicking something accidentally.
holloway
left a comment
holloway
left a comment
There was a problem hiding this comment.
LGTM just minor feedback
2 participants
fixes #1348
adds dedicated "Withdraw@ button in UI, displayed only for active drafts
in withdraw dialog, the user can also add a optional
commentfor the withdrawal