Welcome-page guard: cover upstream sign-in-view (rows 5/6/9)#129

Merged

aspiers merged 11 commits into

mainfrom

welcome-guard-inadequate

Apr 30, 2026

Commits on Apr 30, 2026

test(e2e): reproduce sign-in-view leaks past welcome-page guard

aspiers
and
claude
committed
test(pds-core): add expire-device-account hook for sign-in-view repros

aspiers
and
claude
committed
refactor(pds-core): reuse PDS Kysely handle in expire-device-account hook

aspiers
and
claude
committed
fix(pds-core): bounce sign-in-view leaks past the welcome-page guard

aspiers
and
claude
committed
test(e2e): row 9 needs the login_hint in the PAR body, not the URL

aspiers
and
claude
committed
refactor: address PR #129 review feedback

aspiers
and
claude
committed
test(pds-core): cover sign-in-view bounce branches + extract shared device-bindings helper

aspiers
and
claude
committed
test(pds-core): factor out test scaffolding to drop Sonar duplication

aspiers
and
claude
committed
refactor(pds-core): rename welcome-page-guard → auth-ui-guard

aspiers
and
claude
committed
fix(pds-core): strip prompt=login from stored PAR after a successful OTP cycle

aspiers
and
claude
committed
fix(pds-core): tokenise prompt, opt-out test hooks by default, drop private-taxonomy refs

aspiers
and
claude
committed