Conversation
This fixes a memory leak in pendingReplies
Collaborator
|
Awesome, @tehkaiyu - thanks for the contribution! It looks like the build is failing when testing this change; can you investigate? Will gladly merge the PR once we verify it's a non-breaking change. |
Author
|
Yep I'll take a look this weekend |
Author
|
Hmm, tests seem to pass locally, any chance this is an issue with the travis setup? Travis logs seem to indicate that it can't connect to the amqp port: https://travis-ci.org/hunterloftis/jackrabbit/jobs/548540256
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The exchange has a memory leak that's only noticeable in high volume traffic. We append a callback function to
pendingRepliesbut never remove it once it's called.Here are some screenshots of our worker memory before and after this fix:
After:
