Add "start" and "end" to group_vars.PKNCAresults#549
Open
kiranmaiganji wants to merge 2 commits into
Open
Conversation
billdenney
requested changes
May 28, 2026
Member
billdenney
left a comment
billdenney
left a comment
There was a problem hiding this comment.
Can you please make the requested update? Also, please add a "Closes #" by editing the PR description so that it will auto-close the issue when merged.
| #' @exportS3Method dplyr::group_vars | ||
| group_vars.PKNCAresults <- function(x) { | ||
| group_vars.PKNCAconc(as_PKNCAconc(x)) | ||
| c(group_vars.PKNCAconc(as_PKNCAconc(x)),"start","end") |
Member
There was a problem hiding this comment.
I think that in most of the rest of PKNCA, start and end are first. Can you please change the order so that they will come first? (That will also necessitate changing the tests.)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This update adds "start" and "end" to the output of group_vars.PKNCAresults().
Closes #484