Repository navigation
Conversation
`release.yml` rewrites `hf_xet/Cargo.toml` at release time only (`sed -i '/^version /s/...' hf_xet/Cargo.toml`), so the committed version stayed at 1.6.0 and local builds reported a stale version. Bump it in-tree so dev builds identify themselves correctly. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Hpd3QVfkg7AGwmnxJzdCyf
`metrics.client_version` in the transfer telemetry payload comes from
`env!("CARGO_PKG_VERSION")` in xet_data, which expands to the workspace
version rather than hf_xet's. Since hf_xet is in the workspace `exclude`
list, the two drift: a 1.7.0-dev0 build reported user-agent
`hf_xet/1.7.0-dev0` alongside `client_version: "1.6.0"`.
Bump `[workspace.package]` and the pinned intra-workspace dependency
versions to match, mirroring what bump-crates-version.yml does (same four
crates, same hf_xet/ git_xet/ wasm/ exclusions).
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Hpd3QVfkg7AGwmnxJzdCyf
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using default effort and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Want higher recall? High effort reviews run extra passes and find more bugs. A team admin can switch effort levels in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit cf9912a. Configure here.
The wasm crates are outside the root workspace and carry their own lockfiles, which still pinned the xet-* crates at 1.6.0. ci.yml builds both and then asserts the lockfile has no uncommitted changes, so the stale pins failed "Build WASM". Covers the four lockfiles CI enforces: root, hf_xet, hf_xet_wasm and hf_xet_thin_wasm. examples/xet_pkg_napi and simulation/* carry their own lockfiles too (still at 1.5.3), but nothing builds or checks them. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Hpd3QVfkg7AGwmnxJzdCyf
Collaborator
Author
|
Instead of merging this into main - I am going to build the Python hf-xet==1.7.0-dev1 directly off this branch. That way we aren't bumping the Rust crates to the -dev1 semver semantics that Python uses. |
assafvayner
approved these changes
Sep 25, 2026
Collaborator
Author
|
Not needed since never actually released this, closing. |
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

What
Brings every in-tree version to
1.7.0-dev1so a locally built wheel identifies itself correctly:hf_xet/Cargo.toml—1.6.0→1.7.0-dev1(the PyPI-facing version)[workspace.package] version—1.6.0→1.7.0-dev1xet-runtime/xet-core-structures/xet-client/xet-datadependency versions acrossxet_client,xet_core_structures,xet_data,xet_pkgCargo.lock,hf_xet/Cargo.lock)Why
Two independent version sources feed the client's self-reporting, and neither is committed back to
mainby its release workflow:hf_xet/Cargo.tomlrelease.yml(PyPI)[workspace.package]bump-crates-version.yml(crates.io)metrics.client_versionrelease.ymlrewrites the version inside the release job only:That edit never lands on
main, so the committed version stayed at1.6.0.Separately, the telemetry payload reports:
CARGO_PKG_VERSIONexpands at compile time for the crate containing the macro —xet_data, which takesversion.workspace = true.hf_xetsits in the workspaceexcludelist and is versioned independently, so the two drift apart: a1.7.0-dev0build emitted user-agenthf_xet/1.7.0-dev0alongsideclient_version: "1.6.0".Bumping both together keeps the user-agent and
client_versionconsistent for this dev build.Scope note
The dependency-pin rewrite mirrors exactly what
bump-crates-version.ymldoes (same four crates, samehf_xet/git_xet/wasm/exclusions). Those three excluded crates depend on the workspace crates bypathwith noversionfield, so they need no change.This does not publish anything —
crates-releaseis still a separate manual trigger.Verification
cargo +1.95.0 check -p xet-data -p xet-client -p xet-runtime -p xet-core-structures— clean, all resolving at1.7.0-dev1cargo +1.95.0 test -p xet-data --features simulation --test test_transfer_telemetry— 12 passed, 0 failed1.6.0references in any manifestNote for local builds: the repo needs rustc 1.95 (
sysinfo@0.39.6requires it); 1.94 fails to resolve before it ever reaches these crates.Note
Low Risk
Version and lockfile-only changes with no logic, security, or protocol modifications.
Overview
Aligns all committed crate versions from 1.6.0 to 1.7.0-dev1 so local builds report a consistent version in telemetry and the Python user-agent.
Updates
[workspace.package] versionin the rootCargo.toml, the standalonehf_xetpackage version, and the pinned1.7.0-dev1path dependency versions onxet-runtime,xet-core-structures,xet-client, andxet-datainxet_client,xet_core_structures,xet_data, andxet_pkg. Lockfiles at the repo root, underhf_xet/, and in the WASM crates are refreshed to match.There is no runtime or API behavior change—only manifest and lock metadata so
CARGO_PKG_VERSION(e.g. in telemetryclient_version) matches what release workflows temporarily set onhf_xetwithout committing tomain.Reviewed by Cursor Bugbot for commit 1bf4532. Bugbot is set up for automated code reviews on this repo. Configure here.