feat: add rustls-no-provider TLS feature - #957
Open
valkum wants to merge 1 commit into
Open
Conversation
reqwest has a rustls-no-provider feature for builds that want rustls without the bundled aws-lc-rs provider. Forward it through xet-client, xet-data and hf-xet so consumers can install their own CryptoProvider, such as ring, and keep aws-lc-rs and its cmake build dependency out of the tree. It stays off by default, so existing builds keep rustls with aws-lc-rs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
reqwesthas arustls-no-providerfeature for builds that wantrustlswithout the bundledaws-lc-rsprovider. Forward it throughxet-client,xet-dataandhf-xetso consumers can install their ownCryptoProvider, such asring, and keepaws-lc-rsand itscmakebuild dependency out of the tree.It stays off by default, so existing builds keep
rustlswithaws-lc-rs.Note
Low Risk
Cargo-only feature forwarding with no runtime code changes; default TLS behavior stays on rustls with aws-lc-rs.
Overview
Adds an optional
rustls-no-providerCargo feature onxet-client,xet-data, andhf-xet, wired the same way as existing TLS features:xet-clientenablesreqwest/rustls-no-provider, and the other crates forward it throughxet-client.This lets downstream builds use rustls without the default aws-lc-rs crypto provider so they can install their own
CryptoProvider(e.g. ring) and avoid aws-lc-rs / cmake in the dependency tree. The feature is not indefault, so existingrustls-tlsbehavior is unchanged.Reviewed by Cursor Bugbot for commit 8ffca18. Bugbot is set up for automated code reviews on this repo. Configure here.