Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Breaking change: clients that send the host token on per-sandbox routes stop working. This intentionally removes compatibility, as requested after the security-stack review. Protocol advances from 2 to 3; clients already using scoped tokens work with either. Companion client: huggingface/huggingface_hub#4782.
Land the client first, then release this server and update the client's binary pin. No server or client release is performed by this PR. The host credential still manages the pool and can recover scoped tokens, so it remains sensitive.
GNU and musl unit suites: 51 passed each. Clippy with warnings denied passed. Manual privileged Docker token-scope regression:
All eight root regression scripts passed in a privileged Docker container. The local kernel exposes Landlock ABI 4; this run does not establish ABI 6-specific isolation behavior.