Harden pooled sandbox isolation - #14
Closed
Wauplin wants to merge 1 commit into
Closed
Conversation
Collaborator
Author
|
Closing in favour of a set of smaller PRs, one per finding, so each can be reviewed and reverted on its own. Nothing here is being dropped — the work is redistributed:
Thanks for the Also worth recording: #16 verified both escapes end-to-end against |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to https://huggingface.slack.com/archives/C03Q18WK18T/p1788160539575999, let's see what we want to do first
Summary
Rollout
Deploy this server before the companion huggingface_hub change. Existing clients keep working for non-proxy scoped calls, while pooled proxy calls require the upgraded client. Existing pool host jobs must be recycled after publishing the new bucket binary; otherwise they keep running the old process.
Companion client PR: huggingface/huggingface_hub#4782
Validation