Add ConvBERT to NormalizedConfigManager - #2476
Open
xquantize wants to merge 1 commit into
Open
Conversation
…lizedConfigManager._conf (maps to NormalizedTextConfig) and add it to TEXT_ENCODER_MODELS so the existing dummy-input-generator tests cover it. Addresses part of huggingface#351.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds ConvBERT support to
NormalizedConfigManager, part of the "add all models" effort in #351."convbert"inNormalizedConfigManager._conf, mapping toNormalizedTextConfig(ConvBERT exposes standardhidden_size,num_hidden_layers,num_attention_headsattributes).convberttoTEXT_ENCODER_MODELSin the dummy-input-generator tests, so the existingtest_text_modelssuite now covers it.Verified locally:
pytest tests/utils/test_dummpy_input_generators.py -k textpasses (16 passed), and the normalized config resolves the correct heads/hidden/layers for ConvBERT.Part of #351.
Before submitting