Repository navigation
kernel-builder: quote the stable ABI version in the preamble - #869
Merged
Merged
Conversation
If one backend does not support the stable ABI, `_STABLE_ABI_VERSION` does not have a value. This resulted in a condition not parsing, due to direct variable use. Instead, quote the variable, so that the version evals to an empty string in that case (which won't need evaluation, since the first condition already shortcuts).
sayakpaul
approved these changes
Oct 2, 2026
| set(_STABLE_ABI_VERSION "${_STABLE_ABI_VERSION_${BACKEND}}") | ||
|
|
||
| if(_STABLE_ABI_VERSION AND TORCH_VERSION VERSION_GREATER_EQUAL ${_STABLE_ABI_VERSION}) | ||
| if(_STABLE_ABI_VERSION AND TORCH_VERSION VERSION_GREATER_EQUAL "${_STABLE_ABI_VERSION}") |
Member
Author
There was a problem hiding this comment.
Converting some kernels.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If one backend does not support the stable ABI,
_STABLE_ABI_VERSIONdoes not have a value. This resulted in a condition not parsing, due to direct variable use. Instead, quote the variable, so that the version evals to an empty string in that case (which won't need evaluation, since the first condition already shortcuts).