Repository navigation
feat: reviewed ACP and verifier grants, faster job listing and submission refresh - #242
Merged
Merged
Conversation
(cherry picked from commit 21fba17)
Co-Authored-By: GPT-6 Sol <noreply@pi.dev> Generated-By: pi 0.87.1 (https://pi.dev) (cherry picked from commit 222867e)
Co-Authored-By: GPT-6 Sol <noreply@pi.dev> Generated-By: pi 0.87.1 (https://pi.dev) (cherry picked from commit 5a0b33c)
Co-Authored-By: GPT-6 Sol <noreply@pi.dev> Generated-By: pi 0.87.1 (https://pi.dev) (cherry picked from commit c450f03)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds reviewed credential grants for ACP agents and verifier judges, and two control-service speed fixes. It replaces #241, which also carried a local copy of custom-endpoint support for Harbor's Pi agent. That support already exists upstream in Harbor (
9faf4883, "fix(pi): preserve thinking levels for custom endpoints", #3352), so it is left out here and should arrive with the next Harbor revision bump instead of as a Harbor-HF wrapper.The commits:
fix(presets): admit reviewed ACP endpoint connections. Harbor's ACP agent has nomodel_apioption; its pinned source configures its own client. Admission now accepts an ACP subject without that option but still requires exactly one matching reviewed grant for the agent, model, operator, image and credential reference, and it refuses an ACP record with an injectedmodel_api.feat(inference): deliver scoped verifier judge keys to reviewed runs. A new Space variable,HARBOR_HF_VERIFIER_GRANTS, lists benchmark-scoped judge grants (benchmark and preset, pinned dataset commit and path, worker image digest, judge model and base URL, and a credential reference). At parent Job start the service rechecks the grant and delivers the key as an ephemeralAGENT_JUDGE_API_KEYJob secret, with the URL and model as plain variables. Harbor then resolves the task's own${AGENT_JUDGE_API_KEY:-}verifier entry, so no judge key reaches the run record or trial configuration.fix(jobs): filter Harbor jobs before pagination. The Jobs listing asks the Hub for Harbor-HF's parent and trial roles by label instead of paging through every Job on the account.fix(runs): scope submission projection refresh. After a submission, only the new run is rebuilt in the projection instead of a full refresh, which made submit calls take several minutes.The first three are already running on the control Space. All checks pass locally:
npm run build, the full test suite (102 files, 1723 tests),biome lint,check:generatedand the public privacy check.🤖 Generated with Claude Code