fix: stabilize replacement evidence and contain parent errors - #223
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Harbor-first review
Pinned Harbor:
dcd0a7ac74b7bd417780d9cb27cd819c7ec82e4e(unchanged).Checked native
src/harbor/job.py,job_plan.py,models/job/config.py,models/job/lock.py,models/job/result.py,models/trial/result.py,models/verifier/result.py, andenvironments/hf_sandbox.py, plus their pinned history including native preflight/config validation and HF Sandbox provider/command execution changes.Public APIs checked:
Job.create(),Job.run(),JobPlan.from_resolved,build_trial_configs,aggregate,RetryConfig, andVerifierResult.rewards(float | int).Harbor owns native validation, planning, trial retries, execution and results. Input normalization precedes native validation so Harbor restores declared numeric types. The sole optional durable field,
acknowledged_parent_failures, records an HF-owned operator acknowledgment, not mirrored provider status or Harbor retry state. No new API endpoint, projection table, resource, native field alias, alternate hash or result writer.See
docs/replacement-evidence-parent-containment.mdfor ownership, checked history, compatibility limits and bridge removal condition.Validation and independent review
Release boundary
Release is exact-green-head squash merge, matched immutable worker image publication, and deployment to the existing private control Space with writes temporarily disabled. Fresh idle, provenance and unchanged execution checks gate cutover.
No benchmark launch/resume, replacement submission, inference grant, credential movement/change, paid canary or new resource is included. Deployment does not resume paused work. Offline preflight evidence is not a live-trial claim.