fix: review recorded run inference access for current image - #222
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Harbor ownership and evidence
Checked Harbor
dcd0a7ac74b7bd417780d9cb27cd819c7ec82e4e:src/harbor/models/job/config.py(JobConfigvalidation and agents) andsrc/harbor/models/trial/config.py(AgentConfig, nativekwargs,env,import_path,model_name,extra_allowed_hostsand environment serialization). Relevant path history includes283ef4ee,f633b8a8,abeae607,71180a2e,4861de0band later available history.Harbor owns configuration and execution; Harbor-HF owns authenticated credential policy and console presentation. Reuses
InferenceBindings.selectedand the existing bounded transient review cache/approval API. No new durable schema, mirrored native field, reverse compiler, store, SQLite table or execution state. The optional run proof is ephemeral fencing, not another persisted run format. Seedocs/run-inference-access-review.md.Validation
Known pre-existing gaps (not bypassed or weakened)
The prescribed Slophammer
--baselineinvocation fails because the baseline file is absent. Whole-agent-package coverage remains approximately 77%; this change does not modify agent code. Existing native checksum deprecation and lint warnings remain. An initial browser startup probe stalled; the unchanged complete suite passed against an isolated local test server.Release boundary
Separately authorized publication, exact green-head squash merge, matched existing image workflow and existing private control deployment. No live inference grants, credential movement, paid canary, new resource or benchmark/replacement execution. Deployment remains gated on idle execution, provenance and readiness checks. Full CI passed at exact reviewed head
8e412198561a8e53fb68a8434ffa2e3b3a0ba75c; ready for squash merge.