fix: honor native task names in replacement evidence - #221
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
trial.task_id.get_name(); preserveTrialResult.task_nameunchanged.Harbor ownership review
Checked Harbor
dcd0a7ac74b7bd417780d9cb27cd819c7ec82e4e:src/harbor/models/task/task.py: publicTask.nameuses explicit task metadata, otherwise the directory name.src/harbor/models/task/id.py: publicGitTaskId,LocalTaskId,PackageTaskId.get_name()define task-ID names independently.src/harbor/trial/trial.py: result initialization writestask_name=self.task.nameand the separate native task ID.src/harbor/models/job/lock.py: native lock construction usestask_config.get_task_id().get_name().1d97c20a1(#1285), metadata-name override;7f6ae226b(#1552), task-ID-based lock name.Harbor already owns this distinction: the fix removes a local assumption, not an upstream gap or new wrapper. Existing
JobPlanplanning/aggregation stays authoritative. No persisted or projected field, configuration alias, parser, scheduler or result format is introduced.Validation
linux/amd64.slophammer-py check . --baselinefails because the existing baseline file is absent. Existing agent whole-package coverage gap remains; no threshold was weakened. Native checksum deprecation and existing lint warnings remain.Full diff and metadata reviewed locally in a separate pass. No independent second reviewer is claimed. No inference, benchmark controls, replacement submission or paid benchmark canary was performed.